Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🙈 Hides GUIDs from list views #122

Merged
merged 3 commits into from
Aug 23, 2023
Merged

🙈 Hides GUIDs from list views #122

merged 3 commits into from
Aug 23, 2023

Conversation

afred
Copy link
Contributor

@afred afred commented Aug 23, 2023

  • Removes GUIDs from list views for Collections and Batches.
  • Removes redundant ID from Batch detail view.

@afred
Removes GUIDs from list views
1ce0e81 
* Removes GUIDs from list views for Collections and Batches.
* Removes redundant ID from Batch detail view.
@afred afred temporarily deployed to Codecov August 23, 2023 03:17 — with GitHub Actions Inactive
@afred afred requested a review from mrharpo August 23, 2023 03:17
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023 •
edited
Loading

Codecov Report

Merging #122 (cc38139) into main (3cba93b) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   71.95%   72.14%   +0.18%     
==========================================
  Files          17       17              
  Lines         592      596       +4     
==========================================
+ Hits          426      430       +4     
  Misses        166      166
Files Changed Coverage Δ
chowda/views.py 58.78% <100.00%> (+1.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrharpo mrharpo temporarily deployed to Codecov August 23, 2023 15:06 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov August 23, 2023 15:07 — with GitHub Actions Inactive
@mrharpo mrharpo added the enhancement ➕ New feature or request label Aug 23, 2023
@mrharpo mrharpo added this to the v0.4.0 Chowda 🍲 milestone Aug 23, 2023
@mrharpo mrharpo changed the title Removes GUIDs from list views 🙈 Removes GUIDs from list views Aug 23, 2023
@mrharpo mrharpo temporarily deployed to Codecov August 23, 2023 15:09 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov August 23, 2023 15:09 — with GitHub Actions Inactive
mrharpo
mrharpo approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@mrharpo mrharpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrharpo mrharpo changed the title 🙈 Removes GUIDs from list views 🙈 Hides GUIDs from list views Aug 23, 2023
@mrharpo mrharpo merged commit 14a8602 into main Aug 23, 2023
8 checks passed
@mrharpo mrharpo deleted the remove-guids-from-list-views branch August 23, 2023 15:13
mrharpo added a commit that referenced this pull request Aug 23, 2023
@mrharpo
Merge branch 'main' into batch-media-file-display
616cc2d 
* main:
  🙈 Hides GUIDs from list views (#122)
  Adds 'Duplicate' and 'Combine' actions for Batches. (#121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrharpo mrharpo mrharpo approved these changes

Assignees

@afred afred

Labels
enhancement ➕ New feature or request
Projects
No open projects
Chowda 2023
Status: ✅ Done
Milestone
v0.4.0 Users 👥
Development

Successfully merging this pull request may close these issues.
3 participants
@afred @codecov-commenter @mrharpo