Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏷 Fixes html tag mistmatch in dashboard template #111

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

afred
Copy link
Contributor

@afred afred commented Aug 9, 2023

For some reason there seemed to be an errant closing </div> tag. It was not having an effect on display.

Also removed DataTables from #sync_history, as there was no element with id="sync_history", and when i tried adding it, it errored with DataTables is not defined anyway.

The table of sync history looks fine right now, so scrapping it.

For some reason there seemed to be an errant closing </div> tag. It was not having an effect on display.

Also removed DataTables from #sync_history, as there was no element with id="sync_history", and when
i tried adding it, it errored with "DataTables is not defined" anyway.

The table of sync history looks fine right now, so scrapping it.
@afred afred requested a review from mrharpo August 9, 2023 23:54
@afred afred temporarily deployed to Codecov August 9, 2023 23:54 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #111 (20242d1) into main (4045076) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   77.80%   77.80%           
=======================================
  Files          15       15           
  Lines         491      491           
=======================================
  Hits          382      382           
  Misses        109      109           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrharpo mrharpo temporarily deployed to Codecov August 11, 2023 18:02 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov August 11, 2023 18:02 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov August 11, 2023 18:05 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov August 11, 2023 18:05 — with GitHub Actions Inactive
Copy link
Contributor

@mrharpo mrharpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrharpo mrharpo changed the title Fixes html tag mistmatch in dashbaord template 🏷 Fixes html tag mistmatch in dashboard template Aug 11, 2023
@mrharpo mrharpo added the bug 🐛 Something isn't working label Aug 11, 2023
@mrharpo mrharpo merged commit ca875d7 into main Aug 11, 2023
8 checks passed
@mrharpo mrharpo deleted the fix-dashboard-sync-table branch August 11, 2023 18:08
@mrharpo mrharpo added this to the v0.3 Pipeline 🚰 milestone Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants