Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⭐️ Use Starlette-admin naming convention for template override #102

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

afred
Copy link
Contributor

@afred afred commented Aug 9, 2023

I didn't realize there was a naming convention when originally overriding the custom template, and we are overriding the form element using the naming convention, so... convention over configuration!

Closes #103

@afred afred temporarily deployed to Codecov August 9, 2023 15:18 — with GitHub Actions Inactive
@afred afred requested a review from mrharpo August 9, 2023 15:18
@afred afred temporarily deployed to Codecov August 9, 2023 15:19 — with GitHub Actions Inactive
@afred afred temporarily deployed to Codecov August 9, 2023 15:19 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov August 9, 2023 15:27 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov August 9, 2023 15:27 — with GitHub Actions Inactive
@mrharpo mrharpo changed the title Use Starlette-admin naming convention for template override ⭐️ Use Starlette-admin naming convention for template override Aug 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #102 (85b2c9f) into main (82872a7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   78.18%   78.18%           
=======================================
  Files          15       15           
  Lines         486      486           
=======================================
  Hits          380      380           
  Misses        106      106           
Files Changed Coverage Δ
chowda/views.py 66.66% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrharpo mrharpo temporarily deployed to Codecov August 9, 2023 15:38 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov August 9, 2023 15:38 — with GitHub Actions Inactive
@mrharpo mrharpo added old maintenance 🔧 Old label for Updates and upgrades bug 🐛 Something isn't working labels Aug 9, 2023
Copy link
Contributor

@mrharpo mrharpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrharpo mrharpo merged commit d276b7c into main Aug 9, 2023
8 checks passed
@mrharpo mrharpo deleted the rename-template branch August 9, 2023 15:44
@mrharpo mrharpo added this to the v0.3 Pipeline 🚰 milestone Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working old maintenance 🔧 Old label for Updates and upgrades
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Bug: Batches detail - GUID links broken
3 participants