-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i16 Process subsets #862
Merged
afred
merged 10 commits into
develop
from
i16-missing-instantiations-locator-improvements
Apr 24, 2024
Merged
i16 Process subsets #862
afred
merged 10 commits into
develop
from
i16-missing-instantiations-locator-improvements
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkiahstroud
changed the title
i16 MissingInstantiationsLocator improvements
i16 Audit duplicate XML files + minor improvements
Apr 17, 2024
bkiahstroud
changed the title
i16 Audit duplicate XML files + minor improvements
i16 Process subsets
Apr 23, 2024
Specifically, we're auditing whether their content differs from each other or not. If not, we aren't concerned with handling the duplicates further, but if the content does differ, we need to figure out how
bkiahstroud
force-pushed
the
i16-missing-instantiations-locator-improvements
branch
from
April 23, 2024 20:38
269a593
to
26bacb7
Compare
aprilrieger
previously approved these changes
Apr 23, 2024
bkiahstroud
force-pushed
the
i16-missing-instantiations-locator-improvements
branch
from
April 24, 2024 15:40
09be0d8
to
531f451
Compare
afred
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
various minor improvements
4887565
log if file already exists in target dir
5e04b54
add method to audit duplicate XML files
e43449e
Specifically, we're auditing whether their content differs from each
other or not. If not, we aren't concerned with handling the duplicates
further, but if the content does differ, we need to figure out how
if XML file doesn't exist, capture and log error
2d09bca
add methods to delete/recreate subsets
b5ff103
run migrations on test db schema
269a593