fix: string-view-lite: Include <string> before using std::basic_string
#4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
changed the title
<string> before using std::basic_string<string> before using std::basic_string
StephanTLavavej
force-pushed
the
include-string
branch
from
3daef53
to
509b9d3
Compare
|
Thanks for the fix @StephanTLavavej, and for all the work you do on the STL! |
jackgerrits
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I work on MSVC's STL, and we regularly build popular open-source projects, including yours, with development builds of the MSVC toolset. This allows us to find and fix toolset regressions before they affect users, and also allows us to provide advance notice of breaking changes, which is the case here.
We recently merged microsoft/STL#4633 which will ship in VS 2022 17.11 Preview 3. This improved build throughput by refactoring
<string_view>so that it no longer drags instd::basic_string. Your third-party dependency string-view-lite was affected by this source-breaking change, as it wasn't properly including<string>. When built with our updated STL, this will emit a compiler error:The fix is simple and portable: simply include the necessary header, immediately before it's needed. I've submitted this upstream as martinmoene/string-view-lite#58 .