Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CB_GF): correct update rule and simulation unit test #4565

Merged
merged 7 commits into from
Apr 19, 2023

Conversation

olgavrou
Copy link
Collaborator

  • allow multiple costs if graph feedback

@@ -105,6 +105,7 @@ class cb_explore_adf_base
const multi_ex& ec_seq, VW::io::logger& logger);

ExploreType explore;
static bool allow_multiple_costs;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be static?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes since it is used in predict/learn which are static

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are two workspace instances in the same process, one using cb with graph feedback and one not using it then this static would essentially break that scenario.

If this needs to be dynamic based on the setup then the variable and learn/predict should be non static

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually it doesn't need to be static and good point, updated

@olgavrou olgavrou merged commit 71e2849 into VowpalWabbit:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants