fix: [automl] config oracle edge cases #4327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bassmang
reviewed
Dec 13, 2022
| @@ -187,6 +187,9 @@ void config_oracle<oracle_impl>::insert_config(set_ns_list_t&& new_elements, | |||
| void oracle_rand_impl::gen_ns_groupings_at(const std::string& interaction_type, | |||
| const interaction_vec_t& champ_interactions, const size_t, set_ns_list_t& new_elements, config_type) | |||
| { | |||
| // If champ has no interactions, we can't generate any new configs. | |||
| if (champ_interactions.empty()) { return; } | |||
There was a problem hiding this comment.
What's the point of this? If the champ has no interactions, we should still be able to generate new configs with additional namespaces, namely when the champ is initiated with no interactions
There was a problem hiding this comment.
this would only be empty if you are excluding all the namespaces, so you don't have anything else to add to be excluded
There was a problem hiding this comment.
this is only for the random impl
There was a problem hiding this comment.
not longer applies, see latest
bassmang
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.