refactor: move LabelDict namespace items into other namespaces, add const #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterychang
reviewed
Oct 24, 2022
| @@ -35,6 +35,12 @@ namespace VW | |||
| void copy_example_data(example* dst, const example* src); | |||
| void setup_example(VW::workspace& all, example* ae); | |||
|
|
|||
| void add_example_namespace(VW::example& ec, VW::namespace_index ns, const features& fs); | |||
There was a problem hiding this comment.
should we try to follow std naming conventions at some point? insert/erase instead of add/del?
There was a problem hiding this comment.
These functions are already a bit spooky because the del is actually just a truncate based on the size of the given features. Renaming to insert/erase seems reasonable though
There was a problem hiding this comment.
I think append and truncate better indicate what exactly they do, especially since you cannot give a position to insert at
peterychang
reviewed
Oct 24, 2022
vowpalwabbit/core/src/example.cc
Outdated
| @@ -15,6 +15,58 @@ | |||
| #include <climits> | |||
| #include <cstdint> | |||
|
|
|||
| void VW::del_example_namespace(VW::example& ec, VW::namespace_index ns, const features& fs) | |||
There was a problem hiding this comment.
is this a function that should be exposed directly to users via the public API?
There was a problem hiding this comment.
You're right, this seems like a good candidate for the details namespace
peterychang
approved these changes
Oct 25, 2022
jackgerrits
force-pushed
the
label_dict_change
branch
from
9a4a746
to
eea0c51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.