Add arguments with value to parse-generic #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
scott-vsi
reviewed
May 9, 2024
| @@ -116,7 +117,17 @@ function parse-generic() | |||
| while (( ${#} )); do | |||
| case "${1}" in | |||
| -*) | |||
| # Everything takes zero arguments, so no need to enumerate -d --debug -h --help --nocolor -q --quiet -s --silent -v --verbose --version | |||
| # Anything that takes one arguments from the array arguments_with_value | |||
There was a problem hiding this comment.
Suggested change
| # Anything that takes one arguments from the array arguments_with_value | |
| # Anything that takes one argument from the array arguments_with_value |
| # Everything takes zero arguments, so no need to enumerate -d --debug -h --help --nocolor -q --quiet -s --silent -v --verbose --version | ||
| # Anything that takes one arguments from the array arguments_with_value | ||
| for arg in ${arguments_with_value[@]+"${arguments_with_value[@]}"}; do | ||
| # No need to check "${arg}=", that will be handled as taking "zero argument" below |
There was a problem hiding this comment.
Suggested change
| # No need to check "${arg}=", that will be handled as taking "zero argument" below | |
| # No need to check "${arg}=", that will be handled as taking "zero arguments" below |
| continue 2 | ||
| fi | ||
| done | ||
| # Everything takes zero arguments, so no need to enumerate examples like: -d --debug -h --help |
There was a problem hiding this comment.
Suggested change
| # Everything takes zero arguments, so no need to enumerate examples like: -d --debug -h --help | |
| # Everything else takes zero arguments, so no need to enumerate examples like: -d --debug -h --help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple addition to
parse-genericto support arguments that require one argument.This is still far less strict than previous implementations like the docker compose parse which strictly only allows arguments that are defined in the code, but it opens up the use cases that
generic-parsercan work with by adding very little lift for the dev.