Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker compose refactor #459

Merged
merged 8 commits into from
Sep 7, 2023
Merged

Docker compose refactor #459

merged 8 commits into from
Sep 7, 2023

Conversation

andyneff
Copy link
Member

@andyneff andyneff commented Sep 6, 2023

This is the bulk of the refactor to upgrade from docker-compose version 1 to docker compose version 2

In order to achieve this I had to:

  • Update the test docker images used in CI
  • Remove the - in docker-compose
  • Change DOCKER_COMPOSE into an array
  • Removing Exec-Docker as this seems to never be used
  • Old ci load scripts were not updated, as they will be removed in the near future
  • docker compose build has not been fully replaced with docker buildx bake yet

@andyneff
Bumped into random errorless bug
7a08bd3 
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
@andyneff
Initial docker compose refactor
b38742d 
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
@andyneff
More docker compose v2 conversions
e4cb1e6 
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
@andyneff
Found stray space
3869bee 
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
@andyneff
Revert version number change
1c3a871 
- A new_just test fails if I do that, and too much is going on to worry about that

Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
@andyneff
Unit tests
da8b871 
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
@andyneff
Substr should start at 1, not 0
5eb617d 
- https://invisible-island.net/mawk/CHANGES.html#index-t20090726

Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
@andyneff
Explicitly install awk into opensuse
f20ddba 
Signed-off-by: Andy Neff <andy@visionsystemsinc.com>
@andyneff andyneff self-assigned this Sep 6, 2023
@andyneff andyneff merged commit 594d44d into master Sep 7, 2023
5 checks passed
@andyneff andyneff deleted the docker_compose_refactor branch September 7, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewgilliam drewgilliam drewgilliam approved these changes

@scott-vsi scott-vsi Awaiting requested review from scott-vsi

Assignees

@andyneff andyneff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyneff @drewgilliam