Allow unreferenced strings if they start with '_' #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As briefly discussed in VirusTotal#1937, this change will make it so that any string identifier that starts with '_' can be unreferenced. Any anonymous strings must still be referenced. While testing this out I realized that an unreferenced string still had the STRING_FLAG_FIXED_OFFSET set, which meant any unreferenced string would have a fixed_offset of YR_UNDEFINED. To deal with this when we are reducing the rule we unset STRING_FLAG_FIXED_OFFSET if the string is unreferenced.
plusvic
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As briefly discussed in #1937, this change will make it so that any string identifier that starts with '_' can be unreferenced. Any anonymous strings must still be referenced.
While testing this out I realized that an unreferenced string still had the STRING_FLAG_FIXED_OFFSET set, which meant any unreferenced string would have a fixed_offset of YR_UNDEFINED. To deal with this when we are reducing the rule we unset STRING_FLAG_FIXED_OFFSET if the string is unreferenced.