fix computation of serial correlation factor scct1 #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for a sequence `a0, a1, ..., aN``, scct1 is: `a0 * a1 + ... + a(n-1) * aN + aN * a0` This was badly computed, as instead of computing aN * a0, aN * aN was added instead. This was I guess missed in the tests, because in the only test on serial_correlation, the string used has a0 = aN.
wxsBSD
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Wow, what a great find and thank you for the submission! I think this is correct.
I was able to test it against https://fourmilab.ch/random/ - which is where the idea for a lot of this originally came from - and it was indeed incorrect before. The tests now match what ent is saying for the same data.
plusvic
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for a sequence `a0, a1, ..., aN``, scct1 is:
a0 * a1 + ... + a(n-1) * aN + aN * a0This was badly computed, as instead of computing aN * a0, aN * aN was
added instead.
This was I guess missed in the tests, because in the only test on
serial_correlation, the string used has a0 = aN.