Refactor compiler for clarity #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Blake Williams <blakewilliams@github.com>
|
1 file(s) had their final line ending fixed:
|
joelhawksley
force-pushed
the
refactor
branch
from
c968b8b
to
ccac374
Compare
|
1 file(s) had their final line ending fixed:
|
|
@BlakeWilliams thanks for the thorough review! It was fun to look at ways of incorporating your feedback. I can't help but feel like there is a whole 'nother pass to be done on the compiler. We have a lot of similar logic around finding conflicting render paths that remains awkward as a whole. I wonder if we should land this PR in more or less its current shape and then do a second pass in a follow up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @BlakeWilliams's suggestion, I've refactored the compiler to make it easier to read and understand. I'm sure we could take this even further, but I stopped once I had a clean
Templateclass extracted. Any and all feedback welcome ❤️