add favicon to fix flaky tests #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've recently been seeing some flaky system test failures such as https://github.com/ViewComponent/view_component/actions/runs/10582240672/job/29321458276?pr=2081 with the error `No route matches [GET] "/favicon.ico"`. It appears as though the browser is trying to load a favicon and when it fails to load before the test exits, causes the test to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently been seeing some flaky system test failures such as https://github.com/ViewComponent/view_component/actions/runs/10582240672/job/29321458276?pr=2081 with the error
No route matches [GET] "/favicon.ico". It appears as though the browser is trying to load a favicon and when it fails to load before the test exits, causes the test to fail.