Defer to built-in action caching #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd say it's just legacy. |
|
@boardfish any interest in bringing this PR up to date? |
|
Yep, I'll take a look at this soon! |
boardfish
force-pushed
the
built-in-action-caching
branch
2 times, most recently
from
45ddf5b
to
b1fc788
Compare
|
This is good to go – the failures on Rails |
|
@boardfish I think we might have one more real failure here ❤️ |
boardfish
force-pushed
the
built-in-action-caching
branch
2 times, most recently
from
4ee00c9
to
d87e000
Compare
Uses the Rails version specified in Gemfile.lock.
boardfish
force-pushed
the
built-in-action-caching
branch
from
d87e000
to
d6446e7
Compare
|
That's now fixed 👍 |
joelhawksley
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1937
Instead of using
actions/cachedirectly, defer to thesetup-rubyandsetup-nodeactions' native support, which uses this under the hood.