Add config.include_application_routes to allow skipping inclusion of application routes
#1906
Conversation
…f application routes This comes in handy when using components from within engine that shouldn't access application routes and can opt for including engine routes instead.
|
@elia do you still think this change is a good idea? |
|
@joelhawksley absolutely, will give much more freedom when it comes to using VC within engines. |
|
@elia cool! I'm wondering if there are any other options besides blanket disabling of routes. Can you think of another approach? |
|
@joelhawksley in this case rather than disabling all the routes just puts them behind their "mounted_helpers" so the main app routes are still reachable via Would you prefer a solution always having a set of routes included? Be it the engine's or the main app's? |
My preference is to avoid a breaking change. What do you think? |
What are you trying to accomplish?
Work with components for Rails engines that provide route helpers that should stay separated from the main app routes.
What approach did you choose and why?
Instead of trying to automatically detect and include the engine's routes seems better to just opt out of application routes and manually
include MyGem::Engine.routes.url_helpers.Anything you want to highlight for special attention from reviewers?
Would be even better to opt out of application routes individually for children of
ViewComponent::Baseso that the engine components can have their base class whileApplicationComponentstill gets the app routes by default.