Branch3D #2
Open
Branch3D #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Thanks for the pull request - and sorry for the long delay. Can you please fix the variable names to fit the existing ones (underscores instead of camel case)? Can you further provide a test case? Then I'll be more than happy to merge the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've slightly adapted your code, so it can also be used for calculating the 3D MOT scores. Wanted to use it to benchmark the APIDIS dataset and your code was the only I could find that was easy to read and change. I've basically added a boolean member variable to the class MOTEvaluation, and by setting this variable to true or false it is possible to switch between using the overlap of the bounding boxes and the euclidean distance for calculating the MOTP and MOTA scores. I've also created a new branch for my version of the code, so you can leave your master branch unchanged. So if you think my contribution would be useful would be great if you would add it to your repository.
Stratos