Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Prevent fetching if endpoint was not found #175

Merged
merged 1 commit into from
Jan 24, 2023
Merged

[Fix] Prevent fetching if endpoint was not found #175

merged 1 commit into from
Jan 24, 2023

Conversation

dnwjn
Copy link
Member

@dnwjn dnwjn commented Nov 21, 2022

Implemented a fix for the following exception:

VanOns\Laraberg\Services\OEmbedService::fetch(): Argument #1 ($url) must be of type string, null given, called in /<redacted>/vendor/van-ons/laraberg/src/Services/OEmbedService.php on line 32

@dnwjn dnwjn added bug Something isn't working php Pull requests that update Php code labels Nov 21, 2022
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open for 60 days with no activity.

@mauricewijnia mauricewijnia merged commit bdc23df into main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauricewijnia mauricewijnia Awaiting requested review from mauricewijnia

Assignees

@mauricewijnia mauricewijnia

Labels
bug Something isn't working no-pr-activity php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dnwjn @mauricewijnia