Fix Unity crash on "Open binding UI" when using as package #491
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as package There were two issues causing that crash: - SteamVR_Settings could not be created / stored - SteamVR_Settings missing caused null to be passed to OpenVR.Applications.IdentifyApplication(...) which results in a Unity crash This changeset fixes both issues.
zite
added a commit
that referenced
this pull request
Sep 18, 2019
Changes for 2.4.1b * Some fixes for fallback mode * Fixed some cosmos bindings * Added index hmd proximity binding * Increased default ColliderArraySize for Hands in the Interaction System to 32. * Removed ResolutionDialogSetting warning in Unity 2019.1 (#498) * Fix partial bindings not including default actions (#494) * Fix Unity crash on "Open binding UI" when using as package (#491) * Fix for copy example input files failing on Linux/OSX (#490) * Add Treadmill Source to Input Sources (#486) * 2D Debug: Camera navigation up/down (E/Q) support (#481) * Fixed an issue with Unity throwing "cannot find ın" error in PCs with Turkish default language. (#479) * Exposed useItemPackagePreview (#432) * Modified Throwable to optionally ease into release velocity scaling. (#173)
|
Thanks! Took this pull and put it in the latest beta: https://github.com/ValveSoftware/steamvr_unity_plugin/releases |
zite
added a commit
that referenced
this pull request
Oct 8, 2019
* **BREAKING** actions.json and associated bindings will automatically be moved to the StreamingAssets folder instead of stored in the project root. This removes the need for the plugin to copy them post build and fixes some problems people were having with version control. **IF YOU HAVE A TITLE ON STEAM AND YOU USE THIS TO BUILD - SET THE NEW PATH IN Application/Virtual Reality -> SteamVR Input System -> This game uses SteamVR Input system to: [GameName]_Data/StreamingAssets/SteamVR/actions.json ** * Added properties to SteamVR_Settings to set default models to use when previewing hand poses * Moved default location of SteamVR_Settings.asset to a folder called SteamVR_Resources to make upgrading the plugin easier (can just delete the whole steamvr directory and import again) * Various fixes for mac/linux issues * Pathing fixes to allow nesting of the SteamVR folders * Added a way to easily set the prefab the poser system uses for previews in the editor. Check SteamVR_Settings.asset * Some fixes for fallback mode * Added index hmd proximity binding * Increased default ColliderArraySize for Hands in the Interaction System to 32 * Removed ResolutionDialogSetting warning in Unity 2019.1 (#498) * Fix partial bindings not including default actions (#494) * Fix Unity crash on "Open binding UI" when using as package (#491) * Fix for copy example input files failing on Linux/OSX (#490) * Add Treadmill Source to Input Sources (#486) * 2D Debug: Camera navigation up/down (E/Q) support (#481) * Fixed an issue with Unity throwing "cannot find ın" error in PCs with Turkish default language. (#479) * Exposed useItemPackagePreview (#432) * Modified Throwable to optionally ease into release velocity scaling. (#173) * Updated openvr sdk version to 1.7.15 * Significant performance increases in the input system * Made the hands physical objects that can touch and push things (similar to The Lab) * Added Snap Turn and related actions / bindings * Changed teleport bindings to use joysticks when available * Normalized line endings and trailing spaces across project * Added Vive Cosmos default bindings * Removed the requirements to have a velocityestimator on throwables. * Added SteamVR.GetHeadsetActivityLevel() which will give you the current state of the hmd (idle, in use, etc)
zite
added a commit
that referenced
this pull request
Oct 8, 2019
* **BREAKING** actions.json and associated bindings will automatically be moved to the StreamingAssets folder instead of stored in the project root. This removes the need for the plugin to copy them post build and fixes some problems people were having with version control. **IF YOU HAVE A TITLE ON STEAM AND YOU USE THIS TO BUILD - SET THE NEW PATH IN Application/Virtual Reality -> SteamVR Input System -> This game uses SteamVR Input system to: [GameName]_Data/StreamingAssets/SteamVR/actions.json ** * Added properties to SteamVR_Settings to set default models to use when previewing hand poses * Moved default location of SteamVR_Settings.asset to a folder called SteamVR_Resources to make upgrading the plugin easier (can just delete the whole steamvr directory and import again) * Various fixes for mac/linux issues * Pathing fixes to allow nesting of the SteamVR folders * Added a way to easily set the prefab the poser system uses for previews in the editor. Check SteamVR_Settings.asset * Some fixes for fallback mode * Added index hmd proximity binding * Increased default ColliderArraySize for Hands in the Interaction System to 32 * Removed ResolutionDialogSetting warning in Unity 2019.1 (#498) * Fix partial bindings not including default actions (#494) * Fix Unity crash on "Open binding UI" when using as package (#491) * Fix for copy example input files failing on Linux/OSX (#490) * Add Treadmill Source to Input Sources (#486) * 2D Debug: Camera navigation up/down (E/Q) support (#481) * Fixed an issue with Unity throwing "cannot find ın" error in PCs with Turkish default language. (#479) * Exposed useItemPackagePreview (#432) * Modified Throwable to optionally ease into release velocity scaling. (#173) * Updated openvr sdk version to 1.7.15 * Significant performance increases in the input system * Made the hands physical objects that can touch and push things (similar to The Lab) * Added Snap Turn and related actions / bindings * Changed teleport bindings to use joysticks when available * Normalized line endings and trailing spaces across project * Added Vive Cosmos default bindings * Removed the requirements to have a velocityestimator on throwables. * Added SteamVR.GetHeadsetActivityLevel() which will give you the current state of the hmd (idle, in use, etc)
JaXt0r
added a commit
to Gothic-UnZENity-Project/steamvr-openvr-sdk
that referenced
this pull request
Jun 6, 2024
JaXt0r
added a commit
to Gothic-UnZENity-Project/steamvr-openvr-sdk
that referenced
this pull request
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using SteamVR Unity Plugin as a package (by adding a package manifest / package.json to the SteamVR folder and then adding it via Packages/manifest.json), SteamVR_Settings.asset cannot be created and Unity crashes when you click the button "Open binding UI" in the Window "SteamVR Input".
There were two issues causing that crash:
This pull request fixes both issues by creating the folder, if it isn't available, and not calling OpenVR.Applications.IdentifyApplication(...) if SteamVR_Settings.instance.editorAppKey is null.