fix(secret): do not delete secret if cannot find (opendatahub-io#140)

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
VaishnaviHire · Nov 27, 2023 · 60f0419 · 60f0419
1 parent 0403062
commit 60f0419
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/components/dashboard/dashboard.go b/components/dashboard/dashboard.go
@@ -295,9 +295,10 @@ func (d *Dashboard) cleanOauthClient(cli client.Client, dscispec *dsciv1.DSCInit
 			if !apierrs.IsNotFound(err) {
 				return fmt.Errorf("error getting secret %s: %w", name, err)
 			}
-		}
-		if err := cli.Delete(context.TODO(), oauthClientSecret); err != nil {
-			return fmt.Errorf("error deleting secret %s in namespace %s : %w", name, dscispec.ApplicationsNamespace, err)
+		} else {
+			if err := cli.Delete(context.TODO(), oauthClientSecret); err != nil {
+				return fmt.Errorf("error deleting secret %s in namespace %s : %w", name, dscispec.ApplicationsNamespace, err)
+			}
 		}
 	}
 	return nil