Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add diarization_model argument to CLI #83

Merged
merged 2 commits into from
Nov 30, 2023
Merged

✨ Add diarization_model argument to CLI #83

merged 2 commits into from
Nov 30, 2023

Conversation

kadirnar
Copy link
Contributor

No description provided.

Vaibhavs10
Vaibhavs10 approved these changes Nov 29, 2023
View reviewed changes
Copy link
Owner

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant! Thanks for making this change! This and some refactoring will go into the new release over the weekend! 🤗

P.S. Made a minor comment about updating the diarization model.

src/insanely_fast_whisper/cli.py Outdated Show resolved Hide resolved
@kadirnar @Vaibhavs10
Update src/insanely_fast_whisper/cli.py
7fc8cc4 
Co-authored-by: Vaibhav Srivastav <vaibhavs10@gmail.com>
@Vaibhavs10 Vaibhavs10 merged commit ece23ca into Vaibhavs10:main Nov 30, 2023
@Vaibhavs10
Copy link
Owner

Merging.. thank you!

@Vaibhavs10 Vaibhavs10 mentioned this pull request Nov 30, 2023
Closed
3 tasks
@kadirnar kadirnar deleted the add-diarization-model branch December 1, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vaibhavs10 Vaibhavs10 Vaibhavs10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kadirnar @Vaibhavs10