Allow multiply and divide within component instantiations. #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kmtaylor, please add a news fragment to docs/news.d/. See vunit.github.io > Contributing > Release Notes Instructions and towncrier.readthedocs.io > Tutorial > Creating News Fragments. |
|
I've added the news fragment. Hopefully it's correct. |
markuspg
pushed a commit
to markuspg/vunit
that referenced
this pull request
Sep 25, 2024
…Unit#966) Co-authored-by: Kim Taylor <kimt@blackmagicdesign.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently was getting black boxes because in my instantiation of a component, I had port map lines like
This was because the component search regex was not matching the
/character.(I was compiling with the
--minimalargument)