Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check 4kByte boundary from aligned address #1020

Merged
merged 6 commits into from
May 31, 2024
Merged

Check 4kByte boundary from aligned address #1020

merged 6 commits into from
May 31, 2024

Conversation

ru551n
Copy link
Contributor

@ru551n ru551n commented May 27, 2024

Fixes #1018

LarsAsplund
LarsAsplund reviewed May 29, 2024
View reviewed changes
Copy link
Collaborator

@LarsAsplund LarsAsplund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this, it should be good to merge

vunit/vhdl/verification_components/test/tb_axi_write_slave.vhd Outdated Show resolved Hide resolved
vunit/vhdl/verification_components/test/tb_axi_write_slave.vhd Outdated Show resolved Hide resolved
@LarsAsplund
Copy link
Collaborator

There are some unrelated linting issues due to a new version of pylint. I'm fixing that on master such that you can rebase this branch.

@LarsAsplund
Copy link
Collaborator

master is now fixed.

@LarsAsplund LarsAsplund merged commit 2c0b75e into VUnit:master May 31, 2024
14 checks passed
@LarsAsplund
Copy link
Collaborator

Thanks @ru551n!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LarsAsplund LarsAsplund LarsAsplund left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unaligned accesses to AXI read and write slaves wrongly fail 4kbyte boundary check
2 participants
@ru551n @LarsAsplund