-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vkCom): fonts lodash merge #943
Conversation
Coverage report
Test suite run success422 tests passing in 37 suites. Report generated by 🧪jest coverage report action from 2706648 |
export const vkComFonts = { | ||
...fonts, | ||
fontHeadline: alias('fontHeadline1'), | ||
const vkComFontsPartial: DeepPartial<typeof fonts> = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Выглядит неплохо, но меня смущает, что мы перечисляем все шрифты, и какие-то могут потеряться. Это единственный путь для нас?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
да(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Гуд, спасибо!
Исправляем шрифты для vkcom