fix(ModalRoot): rm preventTouch() #7325
Merged
+10
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
В ущерб проблеме, что при сворачивании `ModalPage` и `ModalCard` может вызываться **pull-to-refresh** (см. #3416), удаляем полифил на `overscroll-behavior-y: none` – метод `preventTouch()`. Удалям по причине не работающих скроллов в интерфейсе – они критичная пробелма, т.к. блокирует действия пользователя. Добавил сноску в документации `Readme.md` про это.
github-actions
bot
added
the
patch
inomdzhon
removed
the
patch
size-limit report 📦
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 3019e02 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7325 +/- ##
==========================================
+ Coverage 83.59% 83.63% +0.04%
==========================================
Files 369 369
Lines 11146 11132 -14
Branches 3641 3638 -3
==========================================
- Hits 9317 9310 -7
+ Misses 1829 1822 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BlackySoul
approved these changes
Aug 6, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
В ущерб проблеме, что при сворачивании
ModalPageиModalCardможет вызываться pull-to-refresh (см. #3416), удаляем полифил наoverscroll-behavior-y: none– методpreventTouch().Удалям по причине не работающих скроллов в интерфейсе – они критичная пробелма, т.к. блокирует действия пользователя.
В PR #6004 добавили установку
overscroll-behavior-y: noneнаhtml, поэтому блокирование pull-to-refresh будет в браузерах, где это CSS свойство поддерживается (см. overscroll-behavior-y | Browser compatibility).Добавил сноску в документации
ModalRoot/Readme.mdпро это ограничение.Изменения
overscroll-behavior-y: noneустанавливался и при первом рендере еслиactiveModal !== null;documentScrolling, т.к. уже не нужен – до этого это условие было полезным, чтобы не плодить событияtouchmove.