Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance #69

Merged
merged 13 commits into from
Aug 6, 2024
Merged

Maintenance #69

merged 13 commits into from
Aug 6, 2024

Conversation

dhodcz2
Copy link
Collaborator

@dhodcz2 dhodcz2 commented Jul 20, 2024

  • Resolved bug with del geocode.address before it is set
  • Restricted python <3.12; as shapely==2.0.1 is incompatible
  • Added .shp to the polygon path file extensions
  • Geopandas 1.0.0 replaced query_bulk with query
  • This commit's test will fail because the Washington DC tile server returns 404 although it is still listed on Google. I am assuming this is related to the CrowdStrike outage and is only temporary. Otherwise when I commented out DC in the tests, they passed. Running in the commandline also passed.

Mary-h86
Mary-h86 reviewed Jul 24, 2024
View reviewed changes
Copy link
Member

@Mary-h86 Mary-h86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the bug with creating raster objects for any general location without a defined source.
There is a comment for fixing the network folder name to add minute.

The rest looks good and local tests are also passed.

src/tile2net/raster/grid.py Outdated
path = os.path.join(poly_fold, f'{self.name}-Polygons-{datetime.datetime.now().strftime("%d-%m-%Y_%H")}')
path = os.path.join(
poly_fold,
f'{self.name}-Polygons-{datetime.datetime.now().strftime("%d-%m-%Y_%H")}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need the minute here as well.

@Mary-h86 Mary-h86 merged commit 60abaab into main Aug 6, 2024
1 check passed
@Mary-h86 Mary-h86 deleted the request branch August 6, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mary-h86 Mary-h86 Mary-h86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhodcz2 @Mary-h86