Updates and small dependencies rework #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, depend on particular version of ffmpeg libs.
Additionally, depend on particular version of ffmpeg libs and fix logos URL.
|
Sorry for the long delay and thanks for your updates! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from updates I changed how dependencies are handled for packages using
ffmpegandlibplacebo. These projects evolve fast, and often the user could update the system, just to spot later that the plugin can't run cause it's linked to older library version. Therefore hardcode library version in dependencies array to prompt the warning before upgrade of the system is commenced, so the package won't end in broken state and user could raise the issue that it needs a rebuild.The last commit is (I assume) temporary workaround of this issue M-Reimer/repo-make#5, so the PR doesn't fail the test build.