Addressed Issue Stop Registration! #755
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in the skelton folder under pages
RohinMarok
changed the title
|
Fixes #624 |
|
ECE444? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution:
I added the stop registration button which doesn't allow users to register after it has been closed. I added the button to work dynamically based on the data returned from an API call effectively conditionally rendering the button based on the team's requirements (this part is commented out in the file but you can comment it back in and route your API calls).
Issue:
After registration closes, hide the "Create Account" button and replace it with "Registration Closed".
There is already some logic in the code that does this, in the following file... client\src\pages\SignUp\SignUp.jsx starting on lines 203.
We want to avoid commenting out the code in the future, so similar to the Landing page #610
Accomplishments: