Fix #120 Add reportLayerColor, getReportedLayerColor, getLayerColor #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpilgrem
force-pushed
the
fix120
branch
7 times, most recently
from
6aeaf0a
to
82f5e5a
Compare
|
Is this related to UnkindPartition/tasty#298? |
|
@Bodigrim, I had not seen that. This PR has been on the back burner, partly because the feature is not really cross-platform yet, even with emulation, for the reasons discussed in the related issue #120. There also does not seem to have been much progress on the Windows Terminal issue. However, I'll think about moving it into the code base. |
…getLayerColor Also adds `hReportLayerColor`, `hGetLayerColor` and `layerColor`. On Windows, emulated using the Windows Console API but the emulation of `reportLayerColor` works only on the native ConHost terminal and not on Windows Terminal. Non-native terminals cannot make use of `getReportedLayerColor`.
|
Great stuff, thanks for release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds
hReportLayerColor,hGetLayerColorandlayerColor.Not supported by terminals on Windows. Native terminals do not allow the color to be reported. Other terminals do not allow the reported color to be read from the console input stream.