Optimize position and factor out logic to compute compressed tick in TickBitmap
#654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2024
Closed
hensha256
reviewed
May 17, 2024
| compressed := | ||
| sub( | ||
| sdiv(tick, tickSpacing), | ||
| // if (tick < 0 && tick % tickSpacing != 0) then tick % tickSpacing < 0, vice versa |
hensha256
previously approved these changes
May 17, 2024
hensha256
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
Description of changes
This pull request is a part of #560 in an effort to ease the review process. It focuses on the
positionfunction and factors out logic to compute compressed tick inTickBitmapalong with fuzz tests.