-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anst/fixes #244
Anst/fixes #244
Conversation
…le was never called)
- "space" in TextArea should not start/stop playback - "delete" or "select all" in TextArea should not affect selected notes - "escape" in TextArea should remove focus from TextArea, not exit the scene - "escape" with content-to-be-pasted should remove content-to-be-pasted, not exit the scene - "escape" with selected notes should deselect notes, not exit the scene
…a single sentence for the notes (instead of one sentence per note) SongEditor: "move to own sentence" action
…cs to newly created note
There are a couple of places where exceptions are handled by just ignoring faulty states instead of at least logging them. That should be improved in the future to make it easier to actually find and resolve problems on users devices which are hard to reproduce... |
I just searched our code for ignored exceptions without logging. Do you have an example in our code? |
What does this PR do?
A minor PR that fixes tons of small issues:
#P1
and#P2
. When these were present, it crashedAlso fixes tons of issues with the song-editor:
Fixed conflicting controls in song-editor:
Will create a new 0.3.1 release when this has been merged