Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anst/fixes #244

Merged
merged 13 commits into from
May 3, 2021
Merged

Anst/fixes #244

merged 13 commits into from
May 3, 2021

Conversation

achimmihca
Copy link
Collaborator

@achimmihca achimmihca commented May 2, 2021

What does this PR do?

A minor PR that fixes tons of small issues:

  • only show available languages in language slider
    • No need to show languages that fall back to English anyway
  • Player profile image was not correctly shown in sing-scene and singing-results-scene
    • was always the default image
  • lyrics when using ScrollingNoteStream were behind their background
    • This made the lyrics more difficult to read instead of easier to read
  • some duet songs were not working. Was using wrong "voice name"
    • in song files, it is possible to provide names for #P1 and #P2. When these were present, it crashed
  • cannot select next/previous song when searching
    • no idea why I added this condition

Also fixes tons of issues with the song-editor:

  • context menu of sentence in song-editor not working
    • the Text component was in front of the raycast target, blocking the context menu
  • sentence should be removed when all its notes are removed
  • faster changing playback position in increments (hold Ctrl and right/left arrow)
    • 1ms is nothing. I increased it to 10ms.
  • assigning new notes to voice was choosing the wrong voice
  • "Move notes to player" and "paste notes" should create a single sentence for the notes (instead of one sentence per note)
  • new "move to own sentence" action
  • wrong font size on notes sometimes
  • fix NPE
  • dont add space as lyrics to newly created note when recording notes

Fixed conflicting controls in song-editor:

  • "space" in TextArea should not start/stop playback
  • "delete" or "select all" in TextArea should not affect selected notes
  • "escape" in TextArea should remove focus from TextArea, not exit the scene
  • "escape" with content-to-be-pasted should cancel content-to-be-pasted, not exit the scene
  • "escape" with selected notes should deselect notes, not exit the scene

Will create a new 0.3.1 release when this has been merged

@basisbit
Copy link
Member

basisbit commented May 2, 2021

There are a couple of places where exceptions are handled by just ignoring faulty states instead of at least logging them. That should be improved in the future to make it easier to actually find and resolve problems on users devices which are hard to reproduce...

@achimmihca achimmihca merged commit 8291345 into master May 3, 2021
@achimmihca achimmihca deleted the anst/fixes branch May 3, 2021 14:33
@achimmihca
Copy link
Collaborator Author

I just searched our code for ignored exceptions without logging.
I did not find any in our code.
I only found few inside "Plugins" folder, i.e., in some libs that we use.

Do you have an example in our code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants