Skip to content

Commit

Permalink
simplify and fix NewVersionChecker (only compare release version, not…
Browse files Browse the repository at this point in the history
… timestamp)
  • Loading branch information
achimmihca committed Mar 4, 2021
1 parent 1b20106 commit 07961b1
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions UltraStar Play/Assets/Scenes/Main/NewVersionChecker.cs
Original file line number Diff line number Diff line change
Expand Up @@ -112,18 +112,10 @@ private void CheckForNewVersion()

localVersionProperties.TryGetValue("release", out string localRelease);

remoteVersionProperties.TryGetValue("build_timestamp", out string remoteBuildTimeStamp);
localVersionProperties.TryGetValue("build_timestamp", out string localBuildTimeStamp);

localVersionProperties.TryGetValue("versionScheme", out string localVersionScheme);
remoteVersionProperties.TryGetValue("versionScheme", out string remoteVersionScheme);

// (localRelease is smaller), or ((localRelease is equal to remoteRelease) and (localBuildTimeStamp is smaller))
try
{
if (CompareVersionString(localRelease, remoteRelease) < 0
|| (CompareVersionString(localRelease, remoteRelease) == 0
&& CompareVersionString(localBuildTimeStamp, remoteBuildTimeStamp) < 0))
if (CompareVersionString(localRelease, remoteRelease) < 0)
{
CreateNewVersionAvailableDialog(remoteVersionProperties);
}
Expand Down

0 comments on commit 07961b1

Please sign in to comment.