refactor: remove audit item creation for list items #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardBray
commented
Jul 11, 2023
src/scheduler/workers/unpublish/day/changeState/resetAnnualReviewForList.ts
Outdated
Show resolved
Hide resolved
jenbutongit
reviewed
Jul 12, 2023
jenbutongit
suggested changes
Jul 12, 2023
src/scheduler/workers/processListsBeforeAndDuringStart/audit.ts
Outdated
Show resolved
Hide resolved
RichardBray
force-pushed
the
chore/1815-remove-unused-audit
branch
2 times, most recently
from
5b42cab
to
faf4296
Compare
jenbutongit
reviewed
Jul 20, 2023
src/server/models/db/migrations/20230717140537_delete_unused_audits/migration.sql
Outdated
Show resolved
Hide resolved
jenbutongit
suggested changes
Jul 20, 2023
jenbutongit
suggested changes
Jul 20, 2023
src/server/models/db/migrations/20230717140537_delete_unused_audits/migration.sql
Outdated
Show resolved
Hide resolved
jenbutongit
suggested changes
Jul 24, 2023
...ns/annual-review/scheduler/an_email_for_the_string_key_date_is_sent_to_eligible_providers.js
Outdated
Show resolved
Hide resolved
src/scheduler/workers/processListsBeforeAndDuringStart/helpers.ts
Outdated
Show resolved
Hide resolved
src/scheduler/workers/processListsBeforeAndDuringStart/helpers.ts
Outdated
Show resolved
Hide resolved
RichardBray
force-pushed
the
chore/1815-remove-unused-audit
branch
from
1dbf9de
to
987b3e4
Compare
jenbutongit
force-pushed
the
chore/1815-remove-unused-audit
branch
2 times, most recently
from
4fcfa1a
to
987b3e4
Compare
RichardBray
force-pushed
the
chore/1815-remove-unused-audit
branch
from
987b3e4
to
a8f85b5
Compare
chore(govuk-notify.ts): change return value of sendAuthenticationEmail, sendApplicationConfirmationEmail, sendDataPublishedEmail, and sendEditDetailsEmail to check for "id" in result and result.id !== undefined chore(notifications-node-client.ts): change statusText to id in mockResolvedValue
… for endAnnualReview
chore(an_email_for_the_string_key_date_is_sent_to_eligible_providers.js): add array to test instead of string chore(audit.ts): add missing export statement for findReminderAuditEvents function chore(govukNotify.ts): update return value of sendAnnualReviewProviderEmail and sendAnnualReviewPostEmail functions chore(helpers.ts): update parameter type of isEmailSentBefore function chore(main.ts): update import statements for Audit and Event types
refactor: rename function names that didn't make sense
…udit enum chore(migrations): add migration to delete unused audits chore(migrations): add migration to update audit enum
… with auditEvent set to 'REMINDER' refactor(listItemEvent.ts): remove unnecessary check for "id" in response
…o Audit and Event tables chore(schema.prisma): add emailType fields to Audit and Event models
chore(the_string_key_date_email_will_be_sent_to_post.js): simplify the where clause in the query to improve readability and maintainability
…eation function to accept additional options for different types of edits
…rom "server/models/listItem/listItemEvent" to "shared/listItemEvent" to resolve import error
RichardBray
force-pushed
the
chore/1815-remove-unused-audit
branch
from
efe1d61
to
289005a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove calls to audit table that are related to list items.
Trello ticket: https://trello.com/c/SDJtNQEZ/1815-remove-deprecated-code-around-audit