Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrations to add missing countries and lists #463

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

RichardBray
Copy link
Contributor

@RichardBray RichardBray commented Sep 16, 2022

Description

The purpose of this PR is to add list for all the counties that exist in the metadata.ts file.

To achieve this, a migration script is first run to add all the missing countries to the Country table.

There are more scripts to add the missing lists for the lawyers, funeralDirectors, and translator services.

Trello ticket: https://trello.com/c/oRK0XZ2h/1443-use-migration-script-for-adding-missing-countries-instead-of-process

@RichardBray RichardBray self-assigned this Sep 16, 2022
@RichardBray RichardBray marked this pull request as ready for review September 16, 2022 10:30
@RichardBray RichardBray changed the title Feat/missing countries migrations Migrations to add missing countries and lists Sep 16, 2022
@RichardBray RichardBray changed the title Migrations to add missing countries and lists chore: migrations to add missing countries and lists Sep 16, 2022
@RichardBray RichardBray force-pushed the feat/missing-countries-migrations branch from 27b7738 to e4a1170 Compare September 16, 2022 14:07
@RichardBray RichardBray added the WIP Work in progress - do not merge label Sep 20, 2022
@RichardBray RichardBray force-pushed the feat/missing-countries-migrations branch from cbedb01 to 08544e8 Compare September 21, 2022 11:55
@RichardBray RichardBray added review requested and removed WIP Work in progress - do not merge labels Sep 22, 2022
@RichardBray RichardBray added question Further information is requested review requested and removed review requested question Further information is requested labels Sep 22, 2022
@RichardBray RichardBray force-pushed the feat/missing-countries-migrations branch 3 times, most recently from 85663aa to 0d0ce65 Compare September 30, 2022 13:55
@RichardBray RichardBray force-pushed the feat/missing-countries-migrations branch from 0d0ce65 to 3c87fcc Compare October 24, 2022 14:35
Copy link
Collaborator

@alisalaman-cyb alisalaman-cyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@alisalaman-cyb alisalaman-cyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RichardBray RichardBray force-pushed the feat/missing-countries-migrations branch from 2e902c0 to 1cb1653 Compare November 16, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants