-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrations to add missing countries and lists #463
Open
RichardBray
wants to merge
26
commits into
master
Choose a base branch
from
feat/missing-countries-migrations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardBray
changed the title
Feat/missing countries migrations
Migrations to add missing countries and lists
Sep 16, 2022
RichardBray
changed the title
Migrations to add missing countries and lists
chore: migrations to add missing countries and lists
Sep 16, 2022
RichardBray
force-pushed
the
feat/missing-countries-migrations
branch
from
September 16, 2022 14:07
27b7738
to
e4a1170
Compare
RichardBray
force-pushed
the
feat/missing-countries-migrations
branch
from
September 21, 2022 11:55
cbedb01
to
08544e8
Compare
RichardBray
added
review requested
and removed
WIP
Work in progress - do not merge
labels
Sep 22, 2022
jenbutongit
suggested changes
Sep 22, 2022
src/server/models/db/migrations/20220913124952_add_missing_countries/migration.sql
Outdated
Show resolved
Hide resolved
src/server/models/db/migrations/20220913124952_add_missing_countries/migration.sql
Show resolved
Hide resolved
src/server/models/db/migrations/20220913152735_missing_countries_lawyers/migration.sql
Show resolved
Hide resolved
src/server/models/db/migrations/20220913152735_missing_countries_lawyers/migration.sql
Show resolved
Hide resolved
...models/db/migrations/20220915141951_missing_countries_translators_interpreters/migration.sql
Outdated
Show resolved
Hide resolved
RichardBray
added
question
Further information is requested
review requested
and removed
review requested
question
Further information is requested
labels
Sep 22, 2022
RichardBray
force-pushed
the
feat/missing-countries-migrations
branch
3 times, most recently
from
September 30, 2022 13:55
85663aa
to
0d0ce65
Compare
RichardBray
force-pushed
the
feat/missing-countries-migrations
branch
from
October 24, 2022 14:35
0d0ce65
to
3c87fcc
Compare
jenbutongit
suggested changes
Oct 26, 2022
src/server/models/db/migrations/20220913152735_missing_countries_lawyers/migration.sql
Show resolved
Hide resolved
RichardBray
added
changes needed
review requested
and removed
review requested
changes needed
labels
Oct 26, 2022
alisalaman-cyb
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alisalaman-cyb
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RichardBray
force-pushed
the
feat/missing-countries-migrations
branch
from
November 16, 2022 17:44
2e902c0
to
1cb1653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to add list for all the counties that exist in the metadata.ts file.
To achieve this, a migration script is first run to add all the missing countries to the Country table.
There are more scripts to add the missing lists for the lawyers, funeralDirectors, and translator services.
Trello ticket: https://trello.com/c/oRK0XZ2h/1443-use-migration-script-for-adding-missing-countries-instead-of-process