Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the Scale-up of HIV, TB, Malaria services go to "MAXIMAL" levels (as well as target levels) #1441

Closed
wants to merge 20 commits into from

Conversation

tdm32
Copy link
Collaborator

@tdm32 tdm32 commented Jul 29, 2024

This PR partly addresses issue #1411 where programme scale-up should be 'target' or 'max'
The parameter for choosing programme scale-up has changed to 'type_of_scaleup' and requires a string, default value is 'none'
in def update_parameters_for_program_scaleup, the values for scale-up parameters are chosen based on this parameter

test_htm_scaleup is also updated

script: comparison_of_vertical_programs/analysis_maxHTM_scenario.py runs scenarios with program scale-up. This only changes scale-up in hiv, tb and malaria and uses the default values for all other modules.

@tdm32 tdm32 requested a review from tbhallett July 29, 2024 12:08
Copy link
Collaborator

@tbhallett tbhallett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tara -- looks like it will do the job nicely!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes from lifestyle coming in again!? Very weird! I'll have to roll back for the version to merge

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it won't run locally with np.timedelta64 value="M" for me:
enhanced_lifestly.py np.timedelta64 as ValueError: Unit M is not supported. Only unambiguous timedelta values durations are supported. Allowed units are 'W', 'D', 'h', 'm', 's', 'ms', 'us', 'ns'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very weird. Matt/Asif would know better but I guess it's to do with perhaps your setup not being quite the same the specification? (In which case delete it and start again with the conda environment setup...?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no...

src/tlo/methods/tb.py Show resolved Hide resolved
resources/ResourceFile_HIV.xlsx Outdated Show resolved Hide resolved
@tbhallett tbhallett changed the title Tara max ht mscenarios setup 29 jul Let the Scale-up of HIV, TB, Malaria services go to "MAXIMAL" levels (as well as target levels) Jul 29, 2024
@tbhallett
Copy link
Collaborator

closing in favour of #1443

(final commit accidentally brought in some unwanted changes that couldn't easily be reverted).

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants