Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove editor custom elements #286

Open
spelkey-ucd opened this issue Feb 21, 2024 · 0 comments
Open

Remove editor custom elements #286

spelkey-ucd opened this issue Feb 21, 2024 · 0 comments
Assignees

Comments

@spelkey-ucd
Copy link
Member

when doing the initial build, we inserted lit custom elements into the editor in order to make the transition to React a bit easier. IMHO, this has ended up causing more problems than it has solved. Now, with the new section block, this is especially evident since a lot of colors are not rendering correctly due to the shadowdom. So, we could either:

  1. disable the shadow dom
  2. remove the offending lit components and use the native wordpress richtext component instead

I think the latter is a better long-term solution since, if the past is any indication, Lit/React compatibility issues will continue to be an issue.

@spelkey-ucd spelkey-ucd self-assigned this Feb 21, 2024
spelkey-ucd added a commit that referenced this issue Feb 21, 2024
spelkey-ucd added a commit that referenced this issue Feb 21, 2024
spelkey-ucd added a commit that referenced this issue Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant