Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change value to pass as an argument (for --prefer-ts-exts) #867

Merged
merged 3 commits into from
Sep 15, 2019

Conversation

nana4gonta
Copy link
Contributor

The --prefer-ts-exts option ( #837 ) seemed to work for CLI arguments but not for environment variables.
There are values that merge environment variables and CLI arguments (index.ts#L197), but --prefer-ts-exts processing seems to use only the values received by CLI.

@coveralls
Copy link

coveralls commented Aug 16, 2019

Coverage Status

Coverage increased (+0.2%) to 85.504% when pulling 405dcf6 on nana4gonta:fix/pass-value into 6295254 on TypeStrong:master.

src/index.ts Outdated
@@ -401,7 +401,7 @@ export function register (opts: Options = {}): Register {
const register: Register = { cwd, compile, getTypeInfo, extensions, ts }

// Register the extensions.
registerExtensions(opts, extensions, ignore, register, originalJsHandler)
registerExtensions(options, extensions, ignore, register, originalJsHandler)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pass through only options.preferTsExts, I think that's the only thing used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I'll fix it.

@nana4gonta
Copy link
Contributor Author

nana4gonta commented Sep 2, 2019

@blakeembrey If this commit ( 405dcf6 ) is OK, I would be very happy if you could merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants