Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix none-node_module imports of built ts files #674

Merged
merged 1 commit into from
Oct 29, 2017

Conversation

Pajn
Copy link
Contributor

@Pajn Pajn commented Oct 26, 2017

fixes #667

@johnnyreilly
Copy link
Member

This looks good! It's a minor change and the existing tests still pass with it which is good.

Generally it's good to have a test to cover changed behaviour to prevent regressions in the future.
Unfortunately it looks tricky to create a test for this will be hard given the difficulties creating a repro.

I think it makes sense to merge and when I release this I'll keep my eyes open for anyone having issues. Hopefully there won't be any.

Thanks so much for drilling into this and coming up with a solution!

@johnnyreilly johnnyreilly merged commit 5e1b477 into TypeStrong:master Oct 29, 2017
@johnnyreilly
Copy link
Member

Published with 3.1.1 - thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error importing buildt ts files with allowJs
2 participants