Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new mock endpoint sample #533

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Added new mock endpoint sample #533

merged 2 commits into from
Nov 21, 2022

Conversation

rewsmith
Copy link
Contributor

@rewsmith rewsmith commented Nov 18, 2022 •
edited
Loading

Added a new mock endpoint to the samples

Description

Not much more to say!

Related Issue

Motivation and Context

We don't currently have a mock sample. The more samples the better.

Test Coverage For This Change

k apply -f httpbin_mock.yaml -n tyk

curl localhost:8080/httpbin/foo
{"foo": "bar"}%

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • Make sure you are updating CHANGELOG.md based on your changes.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • If you've changed API models, please update CRDs.
    • make manifests
    • make helm
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

@rewsmith rewsmith requested a review from a team as a code owner November 18, 2022 11:32
@rewsmith rewsmith requested review from buraksekili and removed request for a team November 18, 2022 11:32
buraksekili
buraksekili approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @rewsmith !

@rewsmith
Copy link
Contributor Author

@buraksekili Can this be merged now?

@buraksekili
Copy link
Member

@rewsmith,  it requires testing from QA before merging; that's why I haven't merged it yet.

@rewsmith
Copy link
Contributor Author

@buraksekili Ah ok, I'll leave it with you then :-)

@rewsmith
Copy link
Contributor Author

@buraksekili @asoorm Just added sample to APIDefinition markdown doc page

@singhpr
Copy link
Contributor

singhpr commented Nov 21, 2022

Tested this PR , it is working fine

@singhpr singhpr merged commit 2220e1b into TykTechnologies:master Nov 21, 2022
@rewsmith rewsmith deleted the mock_sample branch November 22, 2022 13:25
buger pushed a commit that referenced this pull request May 22, 2024
@rewsmith
Added new mock endpoint sample (#533)
f54f461 
* Added mock endpoint example

* Added mock endpoint example and docs

Co-authored-by: Andy Smith <andy@tyk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraksekili buraksekili buraksekili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rewsmith @buraksekili @singhpr