Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

[TT-4528] Improved the documentation regarding the version of cert-manager. #403

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

andrei-tyk
Copy link
Collaborator

@andrei-tyk andrei-tyk commented Mar 1, 2022

Description

Description: with the 1.22 kubernetes update, MutatingWebhookConfiguration API has been removed, this led to older versions that were using this API to stop functioning which meant that our operator could not be installed. Through manual verification I have checked that the minimum cert-manager version that satisfies the 1.22.5 changes is cert-manager:v1.3.0 and I have added the findings in the installation guide.

Related Issue

TT-4528
Resolves #388

Motivation and Context

With the 1.22 kubernetes update, MutatingWebhookConfiguration API has been removed, this led to older versions that were using this API to stop functioning which meant that our operator could not be installed.

Test Coverage For This Change

Through manual verification I have checked that the minimum cert-manager version that satisfies the 1.22.5 changes is cert-manager:v1.3.0 and I have added the findings in the installation guide. Furthermore I have also checked that the previously mentioned cert-manager version (v1.0.3) works with older kubernetes versions (e.g. v1.16.1).

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • gofmt -s -w .
    • go vet ./...
    • golangci-lint run

Description: with the 1.22 kubernetes update, MutatingWebhookConfiguration API has been removed, this led to older versions that were using this API to stop functioning which meant that our operator could not be installed. Through manual verification I have checked that the minimum cert-manager version that satisfies the 1.22.5 changes is cert-manager:v1.3.0 and I have added the findings in the installation guide.
@buraksekili buraksekili changed the title Improved the documentation regarding the version of cert-manager. [TT-4528] Improved the documentation regarding the version of cert-manager. Mar 2, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

8.2% 8.2% Coverage
23.7% 23.7% Duplication

@buraksekili buraksekili merged commit 44cd00d into master Mar 2, 2022
@buraksekili buraksekili deleted the docs/cert-manager-version-issue branch March 2, 2022 13:06
buger pushed a commit that referenced this pull request May 22, 2024
…nager. (#403)

* Improved the documentation regarding the version of cert-manager.

Description: with the 1.22 kubernetes update, MutatingWebhookConfiguration API has been removed, this led to older versions that were using this API to stop functioning which meant that our operator could not be installed. Through manual verification I have checked that the minimum cert-manager version that satisfies the 1.22.5 changes is cert-manager:v1.3.0 and I have added the findings in the installation guide.

* CR feedback: Added link to the supported releases page of cert-manager.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TT-4528] - install docs update for cert-manager version
2 participants