Skip to content

Commit

Permalink
Remove reaper instance from Service Manager.
Browse files Browse the repository at this point in the history
Reaper instantiated only at the time of initialization but never used
later directly by the service manager, hence removing it.
  • Loading branch information
Tuxdude committed Feb 17, 2022
1 parent d75d3c0 commit 18b7e31
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions service_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ type serviceManagerImpl struct {
// that gets terminated.
serviceTermNotificationCh <-chan *terminatedService

// Zombie process reaper.
reaper *zombieReaper
// Service repository.
repo *serviceRepo
// Service janitor.
Expand All @@ -41,9 +39,8 @@ func NewServiceManager(log zzzlogi.Logger, services ...*ServiceInfo) (InitServic
log: log,
}
sm.repo = newServiceRepo(log)
sm.reaper = newZombieReaper(log)
sm.janitor, sm.serviceTermNotificationCh = newServiceJanitor(log, sm.repo, multiServiceMode)
sm.signals = newSignalManager(log, sm.repo, sm.reaper, sm.janitor)
sm.signals = newSignalManager(log, sm.repo, newZombieReaper(log), sm.janitor)

err := launchServices(log, sm.repo, services...)
if err != nil {
Expand Down

0 comments on commit 18b7e31

Please sign in to comment.