Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to prebuild + prebuild-install #1735

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Switched to prebuild + prebuild-install #1735

merged 1 commit into from
Dec 24, 2023

Commits on Dec 24, 2023

  1. Replaced @mapbox/node-pre-gyp in favor of prebuild + `prebuild-in…

    …stall`
    
    fixes #1641
    fixes #1721
    fixes #1714
    fixes #1713
    fixes #1700
    fixes #1704
    
    - `@mapbox/node-pre-gyp` is effectively unmaintained [1] as has a few bugs
      which our users keep running into
    - it seems the prebuilt binary world has moved in favor of prebuild +
      it's various other forms
    - one option would be to use prebuildify to bundle all binaries into the
      package, but that's a step too far removed from the current situation
      for now
    - instead, we can use prebuild-install to download the binaries, and
      `prebuild` to build + upload the binaries
    - this means we can remove node-pre-gyp and fix a bunch of issues!
    - eventually, we could start providing electron prebuilt binaries too
    
    [1]: mapbox/node-pre-gyp#657
    daniellockyer committed Dec 24, 2023
    Configuration menu
    Copy the full SHA
    bd3cf21 View commit details
    Browse the repository at this point in the history