Improve error handling for reading zip files #106
Assignees
Labels
Comments
aileen
added a commit
to aileen/gscan
that referenced
this issue
May 11, 2018
closes TryGhost#106 GScan didn't handle errors `.zip` file errors fully. Furthermore, there is a bug in one of the underlying dependencies, which does not handle and return an error event correctly. Until max-mapper/extract-zip#65 is fixed, we therefore need to use the forked version, which includes the fix here: https://github.com/AileenCGN/extract-zip.git
1 task
aileen
added a commit
to aileen/gscan
that referenced
this issue
May 11, 2018
closes TryGhost#106 GScan didn't handle errors `.zip` file errors fully. Furthermore, there is a bug in one of the underlying dependencies, which does not handle and return an error event correctly. Until max-mapper/extract-zip#65 is fixed, we therefore need to use the forked version, which includes the fix here: https://github.com/AileenCGN/extract-zip.git
aileen
added a commit
to aileen/gscan
that referenced
this issue
May 11, 2018
closes TryGhost#106 GScan didn't handle errors `.zip` file errors fully. Furthermore, there is a bug in one of the underlying dependencies, which does not handle and return an error event correctly. Until max-mapper/extract-zip#65 is fixed, we therefore need to use the forked version, which includes the fix here: https://github.com/AileenCGN/extract-zip.git
aileen
added a commit
that referenced
this issue
May 15, 2018
closes #106 GScan didn't handle errors `.zip` file errors fully. Furthermore, there is a bug in one of the underlying dependencies, which does not handle and return an error event correctly. Until max-mapper/extract-zip#65 is fixed, we therefore need to use the forked version, which includes the fix here: https://github.com/AileenCGN/extract-zip.git
aileen
added a commit
to aileen/Ghost
that referenced
this issue
May 16, 2018
closes TryGhost/Support#426 refs TryGhost/gscan#106 needs TryGhost/gscan#107 GScan can return errors, which was not handled in our theme validator and caused Ghost to crash completely. GScan will now return an Ignition error when its not able to read the `.zip` file. e. g.: `{"errors":[{"message":"Failed to read zip file","context":"tife.zip","errorType":"ValidationError","errorDetails":"invalid relative path: ../tife/"}]}`
aileen
added a commit
to TryGhost/Ghost
that referenced
this issue
May 16, 2018
closes TryGhost/Support#426 refs TryGhost/gscan#106 needs TryGhost/gscan#107 GScan can return errors, which was not handled in our theme validator and caused Ghost to crash completely. GScan will now return an Ignition error when its not able to read the `.zip` file. e. g.: `{"errors":[{"message":"Failed to read zip file","context":"tife.zip","errorType":"ValidationError","errorDetails":"invalid relative path: ../tife/"}]}`
ololoken
pushed a commit
to ololoken/Ghost
that referenced
this issue
May 16, 2018
closes TryGhost/Support#426 refs TryGhost/gscan#106 needs TryGhost/gscan#107 GScan can return errors, which was not handled in our theme validator and caused Ghost to crash completely. GScan will now return an Ignition error when its not able to read the `.zip` file. e. g.: `{"errors":[{"message":"Failed to read zip file","context":"tife.zip","errorType":"ValidationError","errorDetails":"invalid relative path: ../tife/"}]}`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
refs TryGhost/Support#426
GScan can crash (and with it Ghost), when a corrupted zip file is uploaded.
The error happens in a subdependency (yauzl) where an
errorevent is fired, but not handled in the dependency we're using: extract-zipThere's is already an open issue and PR to fix this, but no communication about it yet.
Nevertheless, GScan still needs a better way to handle this situation.
The text was updated successfully, but these errors were encountered: