Skip to content

Commit

Permalink
doc: revise Collaborator Guide on reverting
Browse files Browse the repository at this point in the history
Revise the "Reverting commits" section of the Collaborator Guide. Reduce
passive voice. Increase clarity.

PR-URL: nodejs#25942
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
  • Loading branch information
Trott committed Feb 7, 2019
1 parent a046ae5 commit cf43846
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -285,10 +285,10 @@ after-the-fact.

##### Reverting commits

Commits are reverted with `git revert <HASH>`, or `git revert <FROM>..<TO>` for
multiple commits. Commit metadata and the reason for the revert should be
appended. Commit message rules about line length and subsystem can be ignored.
A Pull Request should be raised and approved like any other change.
Revert commits with `git revert <HASH>` or `git revert <FROM>..<TO>`. The
generated commit message will not have a subsystem and may violate line length
rules. That is OK. Append the reason for the revert and any `Refs` or `Fixes`
metadata. Raise a Pull Request like any other change.

### Introducing New Modules

Expand Down

0 comments on commit cf43846

Please sign in to comment.