Skip to content

Commit

Permalink
test: skip test-cpu-prof in debug builds with code cache
Browse files Browse the repository at this point in the history
The CPU profiler crashes in debug builds when code cache is
enabled. Skip the test temporarily until it's fixed.

PR-URL: nodejs#27308
Refs: nodejs#27307
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
  • Loading branch information
joyeecheung committed Apr 19, 2019
1 parent e0e3084 commit b66f01d
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions test/sequential/test-cpu-prof.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
// This tests that --cpu-prof and --cpu-prof-path works.

const common = require('../common');
if (process.features.debug &&
process.config.variables.node_code_cache_path === 'yes') {
// FIXME(joyeecheung): the profiler crashes when code cache
// is enabled in debug builds.
common.skip('--cpu-prof does not work in debug builds with code cache');
}

const fixtures = require('../common/fixtures');
common.skipIfInspectorDisabled();

Expand Down

0 comments on commit b66f01d

Please sign in to comment.