Skip to content

Commit

Permalink
test: change test to not be sensitive to buffer send size
Browse files Browse the repository at this point in the history
Change the test to not be sensitive to the buffer size causing
TCP resets to be received by the client causing the test to fail.
The test now reads the entire expected buffer and then checks for
the expected event to fire.

PR-URL: nodejs#31499
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
rustyconover authored and Trott committed Feb 29, 2020
1 parent 2b16c13 commit 35f491b
Showing 1 changed file with 11 additions and 6 deletions.
17 changes: 11 additions & 6 deletions test/parallel/test-tls-close-event-after-write.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,30 +12,35 @@ const tls = require('tls');
const fixtures = require('../common/fixtures');
let cconn = null;
let sconn = null;
let read_len = 0;
const buffer_size = 1024 * 1024;

function test() {
if (cconn && sconn) {
cconn.resume();
sconn.resume();
sconn.end(Buffer.alloc(1024 * 1024));
cconn.end();
sconn.end(Buffer.alloc(buffer_size));
}
}

const server = tls.createServer({
key: fixtures.readKey('agent1-key.pem'),
cert: fixtures.readKey('agent1-cert.pem')
}, function(c) {
c.on('close', function() {
server.close();
});
}, (c) => {
c.on('close', common.mustCall(() => server.close()));
sconn = c;
test();
}).listen(0, common.mustCall(function() {
tls.connect(this.address().port, {
rejectUnauthorized: false
}, common.mustCall(function() {
cconn = this;
cconn.on('data', (d) => {
read_len += d.length;
if (read_len === buffer_size) {
cconn.end();
}
});
test();
}));
}));

0 comments on commit 35f491b

Please sign in to comment.