Skip to content

Commit

Permalink
test: enhance test-timers
Browse files Browse the repository at this point in the history
In test-timers, confirm that all input values that should be coerced to
1 ms are not being coerced to a significantly larger value.

This eliminates the need for the separate test-regress-nodejsGH-897.
  • Loading branch information
Trott committed Jan 23, 2017
1 parent 80c72c6 commit 2323569
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 27 deletions.
20 changes: 0 additions & 20 deletions test/parallel/test-regress-GH-897.js

This file was deleted.

22 changes: 15 additions & 7 deletions test/parallel/test-timers.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
require('../common');
const common = require('../common');
const assert = require('assert');

const inputs = [
Expand All @@ -18,13 +18,14 @@ const inputs = [
-10,
-1,
-0.5,
-0.1,
-0.0,
0,
0.0,
0.1,
0.5,
1,
1.0,
10,
2147483648, // browser behaviour: timeouts > 2^31-1 run on next tick
12345678901234 // ditto
];
Expand All @@ -43,10 +44,17 @@ inputs.forEach(function(value, index) {
}, value);
});

process.on('exit', function() {
// assert that all timers have run
// All values in inputs array coerce to 1 ms. Therefore, they should all run
// before a timer set here for 2 ms.

setTimeout(common.mustCall(function() {
// assert that all other timers have run
inputs.forEach(function(value, index) {
assert.strictEqual(true, timeouts[index]);
assert.strictEqual(true, intervals[index]);
assert(timeouts[index]);
assert(intervals[index]);
});
});
}), 2);

// Test 10 ms timeout separately.
setTimeout(common.mustCall(function() {}), 10);
setInterval(common.mustCall(function() { clearInterval(this); }), 10);

0 comments on commit 2323569

Please sign in to comment.