-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle pkcs8 ECDSA keys with missing public parts #62
Comments
No, this is a bug. The public key part of this pkcs8 private key is missing, but it's optional in the RFC and you're supposed to recompute it if it's missing (which sshpk is not currently doing). I'll have a fix for you shortly. |
joyent-automation
pushed a commit
that referenced
this issue
Jan 22, 2019
Reviewed by: Cody Peter Mello <cody.mello@joyent.com>
Fix is merged in master (will be released as 1.16.1 once another commit is reviewed) |
This was referenced Jan 23, 2019
This was referenced Sep 12, 2019
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have been given the following PKCS8 private key, but get this error parsing it.
(This is safe to share.) Is this not a valid private key?
openssl
doesn't complain.https://github.com/joyent/node-sshpk/blob/master/lib/formats/pkcs8.js#L306
Attaching a debugger showed that
Q
is null and not a buffer thatecNormalize(Q)
asserts.Is there something required that is missing from this private key?
The text was updated successfully, but these errors were encountered: