Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shell crash #297

Merged
merged 5 commits into from
Apr 21, 2020
Merged

Fix shell crash #297

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
182cb3d
Updated README
Feb 28, 2020
4ad39af
Implemented changable icons for AppleScriptTouchBarItem
Feb 28, 2020
b118e01
Merge remote-tracking branch 'upstream/master'
FedorZaytsev Mar 30, 2020
c51b6ac
Merge remote-tracking branch 'upstream/master'
FedorZaytsev Apr 12, 2020
542f70d
Fixed error related to ShellButton
FedorZaytsev Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions MTMR/ShellScriptTouchBarItem.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,19 @@ class ShellScriptTouchBarItem: CustomButtonTouchBarItem {

let pipe = Pipe()
task.standardOutput = pipe

// kill process if it is over update interval
DispatchQueue.main.asyncAfter(deadline: .now() + interval) { [weak task] in
task?.terminate()
}

task.launch()

let data = pipe.fileHandleForReading.readDataToEndOfFile()
var output: String = NSString(data: data, encoding: String.Encoding.utf8.rawValue) as String? ?? ""

//always wait until task end or you can catch "task still running" error while accessing task.terminationStatus variable
task.waitUntilExit()
if (output == "" && task.terminationStatus != 0) {
output = "error"
}
Expand Down