Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Productive Gestures #289

Merged
merged 10 commits into from
Apr 8, 2020
Merged

More Productive Gestures #289

merged 10 commits into from
Apr 8, 2020

Conversation

jazzhpatel
Copy link
Contributor

Hey,

So i made some commits to the gestures implementation and added a single finger gesture which allows you to move the caret and the two finger gesture moves the caret a little slower ... i think this would completely change how we use the touch bar ... cuz now you wouldn't have to sacrifice pinky finger health to press arrow keys :)

Please try it and lemme know if this feels better

Copy link
Owner

@Toxblh Toxblh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be so good if don't need to scroll "central" part, which use "default" 1-finger scroll. But better don't reimplement legacy, and use it already like your configuration. And just stay to be able to add some custom behaviour for single finger scroll

README.md Outdated
# Better Gestures Edit!

the commits to the code to get that make the cursor move by sliding on the touchbar ... you know how you could slide on the space bar on your phone ... it’s the same thing but on the touchbar and if you press ALT, it’ll scroll through words and if you press SHIFT, it’ll select the text, like you could move through tabs, just by holding CMD+SHIFT .... and two fingers makes it go slower for precision control ... its just single finger and double finger gestures sending left and right key presses.
brooooooooooooooo
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kek

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But better to move it to Gestures part of Readme

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, I made the readme a little more formal ... also, I changed menu item that said 'volume/brightness gestures' to 'default swipe gestures' so if the user wants to implement custom gestures, they could toggle that off ...

appcast.xml Outdated
@@ -0,0 +1,20 @@
<?xml version="1.0" standalone="yes"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and to del that file

@jazzhpatel
Copy link
Contributor Author

It will be so good if don't need to scroll "central" part, which use "default" 1-finger scroll. But better don't reimplement legacy, and use it already like your configuration. And just stay to be able to add some custom behaviour for single finger scroll

I beg your pardon, I didn't entirely get that ... from what I understand the user could toggle the 'legacy' gestures from the menu if they wish to add their own functionality ...

@Toxblh Toxblh mentioned this pull request Apr 8, 2020
@Toxblh
Copy link
Owner

Toxblh commented Apr 8, 2020

I'll a bit facelift your code after merge.

@Toxblh Toxblh merged commit f61550e into Toxblh:master Apr 8, 2020
Toxblh added a commit that referenced this pull request May 13, 2020
tomeresk pushed a commit to tomeresk/MTMR that referenced this pull request Jul 16, 2021
* Scroll Functionality Works

* updated md

* Update README.md

* Update README.md

* attempted to fix readme

* fixed readme

* fixed readme
tomeresk pushed a commit to tomeresk/MTMR that referenced this pull request Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants